Replace QNetwork operations with libcurl + wolfssl #7771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RipleyTom
force-pushed
the
curlification
branch
from
61bb8f8
to
12752c7
Compare
Megamouse
reviewed
Mar 13, 2020
MSuih
reviewed
Mar 14, 2020
There was a problem hiding this comment.
Here's some stuff that'll fix the most oblivous errors on windows side. It still won't compile even with these fixed due to don't know how to make '3rdparty\wolfssl_cmake\wolfssl.lib', but I think that'll get sorted out once you fix the linux build.
You need to define NOMINMAX, either for whole project in ConfigureCompiler or for the files which use libcurl. If you define it for whole project, remove it from stdafx.h to avoid multiple definition spam.
RipleyTom
force-pushed
the
curlification
branch
from
12752c7
to
a0567e9
Compare
MSuih
reviewed
Mar 15, 2020
RipleyTom
force-pushed
the
curlification
branch
3 times, most recently
from
5ee8ebe
to
82ee6e4
Compare
Megamouse
reviewed
Mar 15, 2020
RipleyTom
force-pushed
the
curlification
branch
7 times, most recently
from
278b24a
to
af1fbbe
Compare
Nekotekina
reviewed
Mar 20, 2020
|
|
||
| #define NOMINMAX | ||
| #define CURL_STATICLIB | ||
| #include <curl/curl.h> |
There was a problem hiding this comment.
CURL probably can be declared as a forward declaration under extern "C"{}, with an actual include in cpp file.
RipleyTom
force-pushed
the
curlification
branch
2 times, most recently
from
d766e3a
to
db81b77
Compare
RipleyTom
force-pushed
the
curlification
branch
3 times, most recently
from
63c8f62
to
ad9ac27
Compare
RipleyTom
force-pushed
the
curlification
branch
from
5234c07
to
df35e4f
Compare
elad335
reviewed
Mar 22, 2020
| } | ||
| } | ||
|
|
||
| // Parse expression(or at least used to, was nuked to remove the need for QtJsEngine) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7575