Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugger improvements #7905

Merged
merged 7 commits into from Apr 3, 2020
Merged

Debugger improvements #7905

merged 7 commits into from Apr 3, 2020

Conversation

VelocityRa
Copy link
Member

@VelocityRa VelocityRa commented Mar 31, 2020 •
edited

  • Made Memory Viewer resizeable
  • Created Call Stack panel with clickable addresses
  • Split register & misc CPU info to separate panels
  • Tweaked relative sizes of all panels to be registers > call stack > misc state > break point list.
  • String & hex previews for register pointers in register dump (heuristic checks for pointers within 2 levels)
  • Don't move entire asm listing if it's not needed

image

@VelocityRa VelocityRa force-pushed the dbg-tuneup branch 5 times, most recently from 5c3e769 to ad20eff Compare March 31, 2020 01:29
@elad335
Copy link
Contributor

elad335 commented Mar 31, 2020

why did you use vm::read64 when I recently fixed it to use *vm::get_super_ptr etc.
vm::g_base_addr should not be used by the debugger at all. use vm::g_sudo_addr instead.

@VelocityRa
Copy link
Member Author

VelocityRa commented Mar 31, 2020 •
edited

cause i was working on an older commit and when rebasing didn't see new funcs

@VelocityRa VelocityRa force-pushed the dbg-tuneup branch 3 times, most recently from 6094a64 to 3c72e40 Compare March 31, 2020 03:37
@VelocityRa
Copy link
Member Author

ready for review

elad335
elad335 requested changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@elad335 elad335 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good overall, just a final rebase nitpick.

rpcs3/Emu/Cell/PPUThread.cpp Show resolved Hide resolved
Megamouse
Megamouse reviewed Mar 31, 2020
View reviewed changes
Copy link
Contributor

@Megamouse Megamouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea if it works. All I did was read the code while making coffee 🤔

rpcs3/Emu/Cell/PPUThread.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/SPUThread.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/SPUThread.cpp Show resolved Hide resolved
rpcs3/Emu/Cell/SPUThread.cpp Show resolved Hide resolved
rpcs3/rpcs3qt/debugger_frame.cpp Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/memory_viewer_panel.cpp Show resolved Hide resolved
rpcs3/rpcs3qt/call_stack_list.cpp Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/call_stack_list.cpp Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/call_stack_list.cpp Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/call_stack_list.h Outdated Show resolved Hide resolved
elad335
elad335 requested changes Mar 31, 2020
View reviewed changes
rpcs3/Emu/Cell/PPUThread.cpp Outdated Show resolved Hide resolved
@VelocityRa
Copy link
Member Author

pushed

@VelocityRa VelocityRa changed the title Debugger improvements [dnm] Debugger improvements Mar 31, 2020
@VelocityRa
Copy link
Member Author

pushed another improvement

@VelocityRa VelocityRa changed the title [dnm] Debugger improvements Debugger improvements Mar 31, 2020
@VelocityRa VelocityRa changed the title Debugger improvements [dnm] Debugger improvements Apr 1, 2020
@VelocityRa VelocityRa changed the title [dnm] Debugger improvements Debugger improvements Apr 1, 2020
elad335
elad335 requested changes Apr 1, 2020
View reviewed changes
rpcs3/Emu/Cell/PPUThread.cpp Outdated Show resolved Hide resolved
@VelocityRa VelocityRa force-pushed the dbg-tuneup branch 4 times, most recently from 09db4e9 to 1685633 Compare April 1, 2020 21:17
@VelocityRa
Copy link
Member Author

pushed

doesn't even need to call .data() or .c_str() on it.

Just tried and it was giving me issues (strings ending at weird places, after first null byte) but .c_str() works so i'm using that.

elad335
elad335 requested changes Apr 1, 2020
View reviewed changes
rpcs3/Emu/Cell/PPUThread.cpp Outdated Show resolved Hide resolved
elad335
elad335 requested changes Apr 1, 2020
View reviewed changes
rpcs3/Emu/Cell/PPUThread.cpp Outdated Show resolved Hide resolved
@AniLeo AniLeo merged commit 2fb600e into RPCS3:master Apr 3, 2020
This was referenced Apr 3, 2020
Merged
Merged
@elad335 elad335 mentioned this pull request Jun 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Megamouse Megamouse Megamouse left review comments

@elad335 elad335 elad335 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@VelocityRa @elad335 @Megamouse @AniLeo