sys_ppu_thread_create: read function descriptor immediately and save it #7988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
changed the title
elad335
force-pushed
the
read-start
branch
2 times, most recently
from
60399f7
to
6911406
Compare
elad335
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function descriptor should be read immediatly in _sys_ppu_thread_create by the calling thread, in interrupt thread it occurs every interrupt is being sent and in other ppu thread types its being done asynchronously by the created thread which both are wrong.
In theory it protects against cases where the function descriptor is being overwritten after the creating thread syscall ended but shouldn't happen in reality in games iirc, so it's just an accuracy improvement.
Also log ppu thread start entry, example:
_sys_ppu_thread_create(): Thread “LIBDG_dummyflip” created (id=0x1000011, func=*0xf8cdc, rtoc=0x3df5e8)