PPU LLVM: Fix rounding regression of FNMADDS, FNMSUBS #8066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know if I am the only one but God of War 3 does not work properly anymore with this build, at least for me. |
|
Upload log file |
|
Okay, no need for that anymore. I fixed it by removing all the configs and custom configs, but thanks anyway :) |
|
The fix itself is correct, it matches behavior from before the regression, so test properly before flagging any regressions |
|
Yes, I will be careful next time. I think it had to do with preserving the config from a custom build I was using till now. I also removed all the caches before testing again and everything was fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #8047, to test this pull request literally remove all rpcs3/cache contents.
The fix itself can merged immediately and the issue will be closed, reopen if still occurs after rpcs3/cache removal.