[msbuild] Minor refactor + VulkanSDK 1.2.135.0+ build fix

[ZeeWanderer]

• cmake cmd line extracted to a variable in spirv and glslang msbuild projects
• decreased VULKAN_SDK lib dir priority to avoid linking provided libs instead of rpcs3-built ones because VulkanSDK 1.2.135.0+ now comes with

glslang.lib
HLSL.lib
OGLCompiler.lib
OSDependent.lib
shaderc.lib
shaderc_combined.lib
shaderc_shared.lib
shaderc_util.lib
SPIRV.lib
spirv-cross-c.lib
spirv-cross-core.lib
spirv-cross-cpp.lib
spirv-cross-c-shared.lib
spirv-cross-glsl.lib
spirv-cross-hlsl.lib
spirv-cross-msl.lib
spirv-cross-reflect.lib
spirv-cross-util.lib
SPIRV-Tools.lib
SPIRV-Tools-link.lib
SPIRV-Tools-opt.lib
SPIRV-Tools-reduce.lib
SPIRV-Tools-shared.lib
SPVRemapper.lib
VkLayer_utils.lib
vulkan-1.lib

[AniLeo]

Better to update SDK version used in CI too

[ZeeWanderer]

This change allows to build with 1.2.135.0 sdk version and should not cause problems for older versions. But ok sure.
EDIT: not sure how to do that for Linux build

[JohnHolmesII]

You would need to pr the number to here:
https://github.com/hcorion/rpcs3-docker/blob/master/xenial/Dockerfile#L47

[kd-11]

Looks fine?? Maybe. The inner workings of visual studio files remains largely a mystery to me, but the reasoning is sound. I have only one suggestion, with spirv opt library shipping with the SDK, we don't need to force build the spirv-tools-build project, making it an optional rebuild like llvm or glslang.

[ZeeWanderer]

@kd-11 spiv-tools and glslang libs provided by VulkanSDK use MD runtime which is strange since it seems like vulkan-1 is statically linked to runtime or at least it does not contain /FAILIFMISMATCH:RuntimeLibrary=MD_DynamicRelease directive. Runtime mismatch error is the reason i noticed the wrong linkage in the first place.

Facepalm, right vulkan-1.lib is pure C so linker has no need to check runtime linkage.

[kd-11]

Ok, then, I suppose current setup will do.