Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glsl: Avoid implicit int->uint conversions #8232

Merged
merged 3 commits into from May 16, 2020
Merged

glsl: Avoid implicit int->uint conversions #8232

merged 3 commits into from May 16, 2020

Conversation

AniLeo
Copy link
Member

@AniLeo AniLeo commented May 15, 2020 •
edited

Silences debug output regarding implicit int -> uint conversions

  • Implicit int -> uint conversions are only an issue on GLES, but this silences unnecessary debug output

@AniLeo AniLeo added the Shaders label May 15, 2020
@AniLeo AniLeo assigned AniLeo and unassigned AniLeo May 15, 2020
@AniLeo
Copy link
Member Author

AniLeo commented May 15, 2020 •
edited

Unsure on how to cast the right part of the bitwise AND on https://github.com/RPCS3/rpcs3/blob/master/rpcs3/Emu/RSX/Common/VertexProgramDecompiler.cpp#L286 since transform_branch_bits is unsigned
I've used a c-style cast, lacking any better idea

@AniLeo AniLeo marked this pull request as ready for review May 16, 2020 01:18
@AniLeo
glsl: Avoid implicit int->uint conversions
4cc8b14 
Silences debug output regarding implicit int -> uint conversions
@AniLeo AniLeo merged commit 99f5145 into RPCS3:master May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kd-11 kd-11 kd-11 approved these changes

Assignees
No one assigned
Labels
Shaders
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AniLeo @kd-11