Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt] Optimize properties in about_dialog #8260

Merged
merged 1 commit into from May 19, 2020

Conversation

sampletext32
Copy link
Contributor

@sampletext32 sampletext32 commented May 18, 2020

fixes #8225

What this PR does

  1. Removes keyboard interaction with labels, so multiple cursors doesn't appear.
  2. Removes double-include resources in about dialog.ui.
  3. Removes some flags as they are in a more general one.

@sampletext32 sampletext32 marked this pull request as ready for review May 18, 2020 21:31
@Megamouse
Copy link
Contributor

you are not fixing anything by removing functionality.
This rather looks like some strange Qt bug instead of our problem

@sampletext32
Copy link
Contributor Author

As was said in issue, text selection behavior is likely undesired and unnecessary in this window. So removing is the thing.
I don't think users really need to copy any of that texts.

All editable or at least selectable texts should be in an EditText control. These are Labels, which usually serves to display texts, but not allow any kind of edit/select.

And it's fixed the issue btw.

@sampletext32
Copy link
Contributor Author

Oh, and welcome_dialog displays the same header, but doesn't allow text selection, so this is another argument to disable it in about_dialog

@sampletext32
Copy link
Contributor Author

Wait a bit, I will run a small test.

@sampletext32 sampletext32 marked this pull request as draft May 19, 2020 00:29
@sampletext32
Copy link
Contributor Author

I've looked through documentation
https://doc.qt.io/qt-5/qt.html#TextInteractionFlag-enum
and found out that only selectableByKeyboard produces cursors.

@sampletext32 sampletext32 changed the title [Qt] Disable text mouse interaction in about_dialog.ui [Qt] Optimize properties in about_dialog May 19, 2020
@sampletext32 sampletext32 marked this pull request as ready for review May 19, 2020 01:13
@sampletext32
Copy link
Contributor Author

Found a solution - text can be selected, but cursors doesn't appear.
image

@Megamouse
Copy link
Contributor

Megamouse commented May 19, 2020

If this works then it is much better. In case you were wondering: Text was made selectable to fix a prior issue, so it was indeed intended.

@Megamouse Megamouse merged commit 3d320ae into RPCS3:master May 19, 2020
@sampletext32 sampletext32 deleted the fix-multiple-cursors branch May 19, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GUI] Multiple cursors in labels
2 participants