New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Qt] Optimize properties in about_dialog #8260
Conversation
6648499
to
e9097b2
Compare
you are not fixing anything by removing functionality. |
As was said in issue, text selection behavior is likely undesired and unnecessary in this window. So removing is the thing. All editable or at least selectable texts should be in an EditText control. These are Labels, which usually serves to display texts, but not allow any kind of edit/select. And it's fixed the issue btw. |
Oh, and welcome_dialog displays the same header, but doesn't allow text selection, so this is another argument to disable it in about_dialog |
Wait a bit, I will run a small test. |
e9097b2
to
f1f5a9a
Compare
I've looked through documentation |
f1f5a9a
to
4ae3762
Compare
If this works then it is much better. In case you were wondering: Text was made selectable to fix a prior issue, so it was indeed intended. |
fixes #8225
What this PR does