Fix some misspells #8264
Merged
Fix some misspells #8264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: in main.cpp there are many dirs similar to Program Files, so tip should be appropriate.
sampletext32
force-pushed
the
fix-misspells
branch
from
abe0fa3
to
f0f9ad5
Compare
Megamouse
reviewed
May 19, 2020
| @@ -233,7 +233,7 @@ | |||
| <addaction name="separator"/> | |||
| <addaction name="actionManage_Users"/> | |||
| <addaction name="confSavedataManagerAct"/> | |||
| <addaction name="actionManage_RAP_Licences"/> | |||
| <addaction name="actionManage_RAP_Licenses"/> | |||
There was a problem hiding this comment.
- "License is both a noun and a verb in the United States."
- "If you live in any other English-speaking country, you will spell it licence when you use it as a noun and license when you use it as a verb."
There was a problem hiding this comment.
https://github.com/RPCS3/rpcs3/blob/master/rpcs3/rpcs3qt/main_window.cpp#L279
This line says about RAP licenSe file and it's definitely not a verb.
https://github.com/RPCS3/rpcs3/blob/7a7ac625cd35c3d59f1d109aa791f2964073c2b0/rpcs3/Emu/Cell/Modules/cellSysutilMisc.cpp
This one contains definition, I believe, directly from hw. USA-like.
Also every GNU headers in files are licenSe. (USA-like)
Main RPCS3 licenSe file is at last USA-like.
So I assume we all use USA-like english and Licenses is correct here
IMHO, it's much easier to use one word instead of two, because it's less confusing and doesn't catch the eye of somebody like me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: in main.cpp there are many dirs similar to Program Files, so tip should be appropriate.