Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nv3089: Account for subpixel addressing #8281

Merged
merged 1 commit into from May 24, 2020
Merged

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented May 23, 2020

Those strange offsets noted in some games seem to match to subpixel addressing. For example, when scaling down by a factor of 4, a pixel offset of 2 will end up inside pixel 0 of the output. Uses coverage area to determine the address (u, v) of the real corner address.

Fixes #5890

- Those strange offsets noted in some games seem to match to subpixel addressing.
  For example, when scaling down by a factor of 4, a pixel offset of 2 will end up inside pixel 0 of the output
@rikimtasu
Copy link

rikimtasu commented May 24, 2020

Doesn't seem to fix it complety,at least on OpenGL mode in 1660 super,latest graphic driver.
Vulkan Mode give a complete black screen while trying to load into a MV.

Heres the log attached.
RPCS3.log.gz

rpcs3_0HXkQR3CT8

EDIT:nvm,it does fixed it on OpenGL mode. I will have to test it after it merge to main build later on.
rpcs3_ZA9pfZY0Bq

rsx_volatitle log:
RPCS3.log.gz

@kd-11 kd-11 changed the title [TESTERS NEEDED] nv3089: Account for subpixel addressing nv3089: Account for subpixel addressing May 24, 2020
@kd-11 kd-11 merged commit bd41a10 into RPCS3:master May 24, 2020
@RainKikyou
Copy link

RainKikyou commented Jul 25, 2020

Sorry, since I haven't looked at github,and i haven't provided detailed information. This is my fault
I tried to switch back to the old driver version, but because win10 does not allow to fault.
I checked the previous information record.These builds are normal graphic,But I think it is a problem with the driver version.

ZXVIF$1}0}N}}~YZTRTDM_D

YO QG{IM{Q8~ 4$ P _1YCS

WO `F397L(GSITJ)R(S_X}Q

T~X )Z9`PYF)3CVU0 QY9L6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VK:IDOLM@STER OFA graphics issue
3 participants