Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch_manager 1.2 #8504

Merged
merged 16 commits into from Jun 29, 2020
Merged

patch_manager 1.2 #8504

merged 16 commits into from Jun 29, 2020

Conversation

Megamouse
Copy link
Contributor

@Megamouse Megamouse commented Jun 26, 2020

DONE:

  • Removed "Patches" Key
  • Added optional "Group" key to avoid stupid choices in the GUI
  • Changed patch dependency to Serial + AppVersion in order to avoid selection of multiple games with the same mouse click

TODO:

  • Test for legacy regressions
  • Test for v1.2 regressions
  • Test import
  • Add option to only show games that are in the gamelist
Version: 1.2

PPU-e72e715d646a94770d1902364bc66fe33b1b6606:
  30FPS:
    Games:
      Best Game Ever:
        NPUA80697: [ 01.00 ]
        NPEA00363: [ 01.00, 01.30 ]
      Best Game Never:
        NPUA80123: [ 01.00 ]
        NPEA00363: [ 01.00, 01.30 ]
    Author: Batman bin Suparman
    Patch Version: 1.0
    Group: FPS
    Notes: ABCD
    Patch:
      - [be32, 0x00010268, 0x9061009C]
      - [be32, 0x008fc864, 0x60000000]
  60FPS:
    Games:
      Best Game Ever:
        NPUA80697: [ 01.00 ]
        NPEA00363: [ 01.00, 01.30 ]
      Best Game Never:
        NPUA80123: [ 01.00 ]
        NPEA00363: [ 01.00, 01.30 ]
    Author: Batman bin Suparman
    Patch Version: 1.0
    Notes: ABCD
    Group: FPS
    Patch:
      - [be32, 0x00010268, 0x9061009C]
      - [be32, 0x008fc864, 0x60000000]
      - [bef32, 0x00012484, 0.01666667]

@HerrHulaHoop
Copy link

I've hit two issues before I could even start testing.

  1. How do we handle cases where Serial is missing (e.g. all SPU patches). Should we write something like All: [ All ]? Would that work?
  2. How do we handle cases where the Patches don't mention the Game Version information? Should we make it compulsory for all patches to record the game version that it works on? Currently, games (like Demon's Souls) that never had updates tend to not have game versions recorded since there's only 1 version.

@Megamouse
Copy link
Contributor Author

Megamouse commented Jun 26, 2020

  • Removed the app version nodes and appended the version to the serials "ABCD12345 v.01.23"
  • Added option to only show games that are in the gamelist
  • Removed the "Collapse All" and "Expand All" buttons in exchange for contextmenu entries

@Megamouse
Copy link
Contributor Author

  • "All" can now be used as a key for title, serial and/or app version.
  • If you enable a patch for any "All", then the patch will be applied regardless of what's checked for the game specifically, because we do not save 'Unchecked' patches.

@Megamouse Megamouse force-pushed the layout branch 5 times, most recently from 994fa54 to 0fbc2b1 Compare June 29, 2020 11:54
This only deals with less than 100 items (that amount is undesirable in the first place)
imported_patch.yml has to be the latest version too
@Megamouse Megamouse marked this pull request as ready for review June 29, 2020 19:42
@Megamouse Megamouse merged commit c6190fa into RPCS3:master Jun 29, 2020
@Megamouse Megamouse added the Patches Patches and Mods label Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Patches Patches and Mods
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants