Unbreak build with Qt 5.15 #8584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpcs3/rpcs3qt/pad_settings_dialog.cpp:674:16: error: variable has incomplete type 'QPainterPath'
QPainterPath path;
^
/usr/local/include/qt5/QtGui/qmatrix.h:54:7: note: forward declaration of 'QPainterPath'
class QPainterPath;
^
|
Qt 5.15.0 is not supported. |
|
RPCS3 built against Qt 5.15.0 works fine on FreeBSD 12.1. Tested Aquapazza and Persona 5, under Xwayland on Sway 1.5. What is not supposed to work? |
|
Qt 5.15.0 broke concurrency, which means that the game window won't show if you own more than maybe 4 games and your cpu supports enough concurrent threads. The bug is already fixed in 5.15.1 according to Qt devs |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed by #8580. FreeBSD recently updated to Qt 5.15. The fix is similar to #7832.