rsx: Simplify support for ABGR formats #8713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the RGBA8 format
|
Fixes broken graphics in GTA IV, a regression caused by #8438. Before: After: Unrelated to this, skybox is now fixed. Previously, it looked like this: |
|
Fixed some Red-blue channel swapping when capturing screenshots. |
|
Fixed bogus error message about format not being supported, was a typo on my side. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map these formats to RGBA layout. While this layout was not supported by some drivers when Vulkan launched, things have improved a lot over the years and now RGBA layout is widely supported. This avoids using compute shaders and sampler swizzle shenanigans in several places.
Fixes #8456