MSVC changes #8732
MSVC changes #8732
Conversation
Add support for compilation on x64 toolchain (x86 cl.exe was running out of heap space in vm.cpp) Also took the opportunity to change compile optimisation from /Ox to /O2, as /O2 provides better optimisation than does /Ox Also, we shouldn't be explicitely setting compiler tool defines (__cpp_lib_bitops), so remove that from types.h
|
I'd wait a bit for people to update their compilers before removing that define. Edit: Even the azure build failed because of it. |
As noted, we've done something we shouldn't have with MSVC compiler specific defines. But to avoid breaking the MSVC build environment, leave this define in there until the MSVC version when it is actually exposed by the compiler itself (v16.8).
I think somehow we got into this tricky situation where we are defining a name which is strictly reserved for the tools. |
|
so in which way was this a hotfix again? |
|
Spams this: |
Yeah.. that'll be my fault for this poor effort (L21): It should read: |
Add support for compilation on x64 toolchain (x86 cl.exe was running out of heap space in vm.cpp)
Also took the opportunity to change compile optimisation from /Ox to /O2, as /O2 provides better optimisation than does /Ox
Also, we shouldn't be explicitly setting compiler tool defines (__cpp_lib_bitops), so remove that from types.h