Another huge atomic.cpp commit #9209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nekotekina
force-pushed
the
fixup
branch
3 times, most recently
from
bb2f3fb
to
2fa7eb4
Compare
But nobody uses it anyway, so clean up includes.
Wait/notify only on c_sig, should reduce spurious wakeup noise.
Add pointer comparison to notifiers (to prevent spurious wakeups). Fix a bug with a possible double notification in raw_notify(). Fix a bug with incorrect allocatin bit slots for cond_handle. Add a semaphore counter to track max allowed number of threads. Use #define for some constants to STRINGIZE them in errors. Add some error messages when certain limits are reached. Fix a bug with a wrong check simply throwing std::abort. Use "special" notify_all patch with batch processing for every arch. Fix Win7 bug who no one probably noticed.
Add ref counters for internal semaphores for concurrent notifying. Lack of them could result in loss of notification.
Nekotekina
force-pushed
the
fixup
branch
2 times, most recently
from
9a5964c
to
87614e8
Compare
Only compare masks for overlap for second overload (with mask provided). Explicit "new value" can be provided in new 3-arg overloads. Also rename atomic_storage_futex -> atomic_wait_engine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.