Hotfix for shm->map_self() #9230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure mmap returns 64K-aligned results, as on Windows.
elad335
reviewed
Nov 8, 2020
| const u64 res64 = reinterpret_cast<u64>(::mmap(reinterpret_cast<void*>(ptr64), m_size + 0xe000, PROT_NONE, MAP_ANON | MAP_PRIVATE, -1, 0)); | ||
|
|
||
| const u64 aligned = ::align(res64, 0x10000); | ||
| const auto result = ::mmap(reinterpret_cast<void*>(aligned), m_size, +prot, MAP_SHARED | MAP_FIXED, m_file, 0); |
There was a problem hiding this comment.
shouldnt this run in a loop? for cases where other thread just mmap on the same range inbetween. until second mmap call succeeds.
There was a problem hiding this comment.
mmap with MAP_FIXED flag just overwrites previous mapping, fully or partially.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure mmap returns 64K-aligned results, as on Windows.
Does not affect Windows, but RPCS3 relies on this logic so need a little workaround.