BOM nuke #9374
BOM nuke #9374
Conversation
| @@ -1,4 +1,4 @@ | |||
| #pragma once | |||
| #pragma once | |||
|
|
|||
There was a problem hiding this comment.
If I recall correctly this broke some special characters like the microsecond abbreviation. Or maybe it was the addition of BOM. Need to test. Maybe it's currently broken on master anyway
There was a problem hiding this comment.
Yes because we didn't have the /utf-8 option for msvc so it didn't interpret stuff as utf-8 unless it had the bom marker.
Now that the option has been added bom or no bom shouldn't matter but it's better to remove it, mainly because of the gcc bug(where it ignores #pragma once on headers with BOM).
|
Make sure you remove BOM only from files which are pure printable ASCII. You can use grep to find such ones. |
|
I forgot, /utf-8 key should be added in .props files as well, and probably cmake. |
|
Also there was an interesting proposal with git-commit hooks, it may work, but I'd prefer it not only check for the absence of BOM but also scan file for any non-ASCII characters as well. |
|
Added to CMakeList.txt and I've changed to using rpcs3_default.props before your comment(and it's used by every .vcxproj from rpcs3 as a baseline, I've checked). As for scanning for non-ASCII chars with githook it's doable but I don't really see a purpose for it, our print functions handle utf-8 just fine so I'm not sure where it would be an issue if there were one non-ascii char in there. |
|
Ok, I'll add some BOM later. |
Adds /utf-8 option to the vcxprojs and removes all the bom markers in /rpcs3/ subdirectory for .cpp and .h files.
There are 2 commits, one with the actual changes to projects and config and the other with all the bom markers removed.