Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsx: Misc fixes #9471

Merged
merged 3 commits into from
Dec 24, 2020
Merged

rsx: Misc fixes #9471

merged 3 commits into from
Dec 24, 2020

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Dec 19, 2020

  • Fix vulkan spec violation on incomplete push constant update
  • Fix vulkan spec violation on linear filter on format that does not support linear filtering
  • Refactor shader codegen header and move the code to cpp file (part of ongoing header simplification)
  • Do not clamp Z coordinate when depth content format is float

Fixes #9447
Fixes #8642

@Satan86
Copy link

Satan86 commented Dec 19, 2020

GT5 running on GTX 1050 ti. Normal gameplay is fine, but some cutscenes and replay cameras look like this
unknown

@kd-11 kd-11 changed the title [TESTERS NEEDED] rsx: Misc fixes [WIP][TESTERS NEEDED] rsx: Misc fixes Dec 20, 2020
@kd-11
Copy link
Contributor Author

kd-11 commented Dec 20, 2020

@Satan86 I fixed a problematic typo, please retest.

@Satan86
Copy link

Satan86 commented Dec 20, 2020

GT5 works fine now

@Satan86
Copy link

Satan86 commented Dec 20, 2020

Actually, scratch that. I just noticed that the game doesn't render any sort of smoke. Same issue in the first commit, so it went unnoticed by me yesterday

@GitArUs
Copy link
Contributor

GitArUs commented Dec 20, 2020 •
edited

With this PR Final Fantasy XIII-2 (BLES01269) crashes during intro battle or during loading of shader cache if it was first created by RPCS3 master:

·F 0:03:22.246976 {RSX [0xaaccf88]} SIG: Thread terminated due to fatal error: Verification failed
(in file /home/user/PS3/kd11/rpcs3/Emu/RSX/Common/GLSLCommon.cpp:690, in function insert_glsl_legacy_function) (errno=2)

OS: Linux
GPU: NVidia RTX2070
driver: 450.80.02 and 460.27.04

Log:
RPCS3.log

Update: also found a moment in FFXIII when the same happens (chapter 1, just after Vanille and Hope steal flying bike).

@Gh0st1996
Copy link

This PR fixed the broken graphics in The Last of Us on my Radeon RX 5700.
The lighting is still a bit "off" sometimes, but this is just a minor issue.

Master:
Master

PR:
PR

PR + Strict Rendering Mode enabled:
PR + Strict Rendering Mode

@noorar89
Copy link

noorar89 commented Dec 23, 2020 •
edited

This PR fixed the broken graphics in The Last of Us on my Radeon RX 5700.
The lighting is still a bit "off" sometimes, but this is just a minor issue.

Master:
Master

PR:
PR

PR + Strict Rendering Mode enabled:
PR + Strict Rendering Mode

I confirm this also fixes the same issue on Radeon Pro 5500m

@kd-11
vk: Fix more spec violations
ca2b1a4
@kd-11
rsx: Refactor shader codegen and fix shadow sampling on depth-float
8ba58e7
@kd-11
rsx: Do not rely on program env state, instead, always use program uc…
b193531 
…ode analysis results when doing codegen

- Some things can be present in program env but not ucode state
  e.g A texture can be active and bound in a redirected manner but not actually be used in ucode
  In such a case, only the ucode analysis or decompilation can decide whether to inject decoding routines
@kd-11 kd-11 changed the title [WIP][TESTERS NEEDED] rsx: Misc fixes [TESTERS NEEDED] rsx: Misc fixes Dec 24, 2020
@kd-11
Copy link
Contributor Author

kd-11 commented Dec 24, 2020

Regressions fixed. Please retest.

@PawTM
Copy link

PawTM commented Dec 24, 2020

Just tried GT5, Smoke is back and Cinematics look normal again
grafik

@noorar89
Copy link

noorar89 commented Dec 24, 2020 •
edited

RDNA issues persist as tested on Radeon Pro 5500m. Broken graphics issue remains for The Last of Us, strict rendering mode does help partially but it hampers performance & induces more crashes. Below image is with strict rendering mode:

Capture2

kudos for the awesome work !

@kd-11 kd-11 changed the title [TESTERS NEEDED] rsx: Misc fixes rsx: Misc fixes Dec 24, 2020
@kd-11 kd-11 merged commit a96b441 into RPCS3:master Dec 24, 2020
@AniLeo AniLeo mentioned this pull request Dec 24, 2020
Closed
16 tasks
@MineSAT
Copy link

MineSAT commented Dec 25, 2020

Regression on shadows and text in Sly Cooper Thieves in Time:
image
image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression: MGS4 High Precision Z-buffer (#8869) GT5 has broken text rendering on RADV
7 participants
@kd-11 @Satan86 @GitArUs @Gh0st1996 @noorar89 @PawTM @MineSAT