Cleanup stdafx.h #9483
Merged
Cleanup stdafx.h #9483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are better memleak detection tools. 1) Requires to guard placement new and external libs 2) Doesn't work thoroughly
It's file for precompiled headers. Include what is used, don't rely on transitive includes.
Also remove some forward declarations from util/types.hpp If they don't work properly, it's easier to remove them.
Can workaround some possible problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a header used by precompiled header support (not enabled in rpcs3qt anyway).
Including it in another headers leaves a bad taste in the mouth.
Added NOMINMAX definition in project configuration.
Removed half-arsed half-dead MemLeak build.