Warnings: Micro fixes #9513
Merged
Warnings: Micro fixes #9513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning of no return value sounds pretty legitimate to me, just make the "throwing" functions [[noreturn]]. |
|
@JohnHolmesII I made _bit deprecated since it's only used in few places and there are different approaches, possibly more elegant. I only get about 20 warnings about it, not sure about clang. I'll try to do something about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return-type warning was spammed everywhere, and was caused by custom exception thing. Best to just disable.
Marking noreturn seems to have left some warnings in, but i cant track them down in compiler explorer (I'm probably just blind).
@Nekotekina The other thing I would really like to get in here is a new indexer for v128 bit vectors, since you marked the old one deprecated. Whenever rpcs3 is updated it nukes my whole terminal because of the warnings. Do you have a plan for replacing it, or perhaps some instructions for someone else to be able to change it?