vm: implement vm::atomic_op, fetch_op helpers #9523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
reviewed
Dec 30, 2020
rpcs3/Emu/Cell/Modules/cellSpurs.cpp
Outdated
| const s32 _new = val + value; | ||
| val = static_cast<u8>(std::clamp<s32>(_new, 0, 255)); | ||
| }); | ||
| val = static_cast<u8>(std::clamp<s64>(val + s64{value}, 0, 255)); |
There was a problem hiding this comment.
I think fw uses CMPWI instructions here for clamping, its ok for now, I'll check it later and worst case ill partially revert it.
There was a problem hiding this comment.
May need to emulate signed overflow without UB, unless it's just impossible.
There was a problem hiding this comment.
Nvm, I think I fixed it. Just use unsigned arithmetic.
Can help to reduce lambda depth hell a little.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can help to reduce lambda depth hell a little.