Random stuff #9589
Merged
Random stuff #9589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Megamouse
commented
Jan 11, 2021
Megamouse
commented
- Rename "Enter" button in OSK to "Return" to minimize confusion.
- Simplify Qt OSK dialog a bit.
- Apply some coding style changes that I came across while debugging.
- Use std::none_of and std::any_of instead of std::find_if (just playing around with new stuff I didn't know before)
- use sv in swizzle comparison (maybe this was intentional and i should remove it ?)
idk, I'll remove this if it was intentional.
This one confused me and make me look for a bug that caused the "enter" key to be disabled, while it was actually the return key (obviously xD).
kd-11
reviewed
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.