Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report execution access violations #9661

Merged
merged 2 commits into from Jan 27, 2021
Merged

Conversation

Nekotekina
Copy link
Member

Don't try to handle it, treat as fatal.

Don't try to handle it, treat as fatal.
@Nekotekina
Copy link
Member Author

Nekotekina commented Jan 27, 2021

On Windows it resulted in incorrect "writing" report.
On Linux it could just freeze at the point (possibly trying to handle it as "reading").

@elad335
Copy link
Contributor

elad335 commented Jan 27, 2021

Can check RIP register on windows, if vm::try_get_addr succeeds on it fail with fatal.

@Nekotekina
Copy link
Member Author

Nekotekina commented Jan 27, 2021

For what purpose? What difference would it make? PS3 vm never allows direct execution in any case.

@elad335
Copy link
Contributor

elad335 commented Jan 27, 2021

For the purpose described in pr description?

@elad335
Copy link
Contributor

elad335 commented Jan 27, 2021

ah I misunderstood the comment #9661 (comment)

@Nekotekina Nekotekina changed the title Detect execution access violation Report execution access violations Jan 27, 2021
@Nekotekina Nekotekina merged commit 15ed963 into RPCS3:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants