Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

60fps shader loading dialog #9691

Merged
merged 3 commits into from Jan 31, 2021
Merged

60fps shader loading dialog #9691

merged 3 commits into from Jan 31, 2021

Conversation

Megamouse
Copy link
Contributor

  • Updates the native shader loading dialog at a much smoother 60fps instead of the jittery 10fps we currently have.
    The smoother update feels much faster and the additional load should be neglectible, especially with multithreading.

  • Implements and uses set_value for the native progress dialogs, following my earlier change to the Qt message dialog.
    This will come in handy later on and also simplifies some existing code.

@kd-11
Copy link
Contributor

kd-11 commented Jan 31, 2021

One of the reasons we chose to only update at 10fps was because of latency issues in flip. When Vsync is enabled, the command to queue a new frame to the display actually waits which is obviously not great. This is why flip was only done once in 100ms. This means if you flip every time you call set_value, you're adding an extra 16ms sleep hidden inside the function call.
EDIT: On second thought this should be ok. I forgot the new mechanism flips from main thread but compilation is done separately.

@Megamouse Megamouse merged commit be26810 into RPCS3:master Jan 31, 2021
@Megamouse Megamouse deleted the discord branch January 31, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants