[Please test] Optimize g_fxo and future typemaps #9714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
reviewed
Feb 3, 2021
|
Working on proper dynamic type handling. |
Nekotekina
force-pushed
the
master
branch
2 times, most recently
from
ef1aeb0
to
76f9d63
Compare
elad335
reviewed
Feb 5, 2021
|
|
||
| // Obtain object pointer if initialized | ||
| template <typename T> | ||
| T* try_get() const noexcept |
There was a problem hiding this comment.
Maybe can be written after pr but I think get() should return a reference and not a pointer to emphasize the fact that it won't return nullptr on failure.
There was a problem hiding this comment.
I technically agree but too many spam changes.
elad335
reviewed
Feb 5, 2021
|
Seems to almost work now. |
|
Fixed more bugs, maybe it's finally mergeable. |
Nekotekina
changed the title
|
Ah I see, damn it. |
Nekotekina
force-pushed
the
master
branch
2 times, most recently
from
8dc3bf3
to
dc7dbc0
Compare
|
Yay! Who is ready to suffer insufferable regressions? Just kidding, I think I'll modify get() operator in this PR as well. |
Nekotekina
changed the title
Nekotekina
force-pushed
the
master
branch
2 times, most recently
from
e0f5b6c
to
af80c43
Compare
This allows contiguous allocation (as in an aggregate).
Implement is_init() method. Implement optional Size template arg for further optimization.
Backported some changes from auto_typemap.hpp Implemented methods init(), reset(), clear() Disabled recreation support.
Fix few misused threads and other bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce pointer indirection.