vk: Support incomplete lavapipe #9761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable features still unimplemented by lavapipe when using it: - samplerAnisotropy - shaderStorageBufferArrayDynamicIndexing - wideLines as of mesa 21.1.0-dev (aea36ee05e9, 2020-02-10)
kd-11
approved these changes
Feb 11, 2021
There was a problem hiding this comment.
Lgtm.
The reason for not disabling these normally is that we need these features for rendering. Lavapipe 'just works' even though they're not enabled here, so an exception makes sense. If things like dynamic ssbo indexing were actually unsupported our compute shaders wouldn't run.
|
Demon's Souls hard crashed (new game) after this update. All settings are default besides white color buffers. |
|
Impossible this update did that, look at the way the code was written |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable features still unimplemented by lavapipe when using it:
as of mesa 21.1.0-dev (aea36ee05e9, 2021-02-10)
Ideally we also need to disable Anisotropic Filtering on runtime in order to not violate Vulkan spec, but it works as is for now
Some games work such as Demon's Souls and Drakengard 3 (tested on mobile i7-6700HQ)
Naturally, as lavapipe improves, so will performance
Partially solves #9642 as lavapipe is Mesa's software mode Vulkan driver