Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rock Band drums #9804

Closed
wants to merge 1 commit into from
Closed

Fix Rock Band drums #9804

wants to merge 1 commit into from

Conversation

DrGeelfood
Copy link
Contributor

No description provided.

@Megamouse
Copy link
Contributor

I think there might be more than one drum kit. Those values were taken from official sources.

@Megamouse
Copy link
Contributor

You're probably trying to add the midi pro adapter. Which should be different

@RipleyTom
Copy link
Contributor

0x210 for drum is correct, it was REd from a game as it was from my initial PR(Guitar Hero probably).
0x0210 to 0x021F are all Harmonix Drums according to some games usb checks(probably different versions).

What does this PR fix exactly?

@DrGeelfood
Copy link
Contributor Author

You're probably trying to add the midi pro adapter. Which should be different

With these values the device shows up and works properly as drums in both RB1 and RB3, so they should be good throughout. Pro drums also work in 3.

@Megamouse
Copy link
Contributor

But you're removing the other drum. Which is wrong

@DrGeelfood
Copy link
Contributor Author

@Megamouse If we feel very strongly about letting the user choose to specifically emulate the pre-RB3 drums, we can reject this one.
The idea is that with this change all existing functionality would be preserved, the only difference is that the emulated RB drums would now also work in RB3. Somewhere down the line I imagine we (meaning someone with access to the actual physical devices) could add separate entries for the RB1, RB2 and Beatles drums for the sake of completeness.

@Megamouse
Copy link
Contributor

please test #9822

@Nekotekina
Copy link
Member

Closing as merged.

@Nekotekina Nekotekina closed this Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants