Firmware installation bugfixes part 1 #9855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elad335
commented
Feb 27, 2021
•
elad335
commented
- Fix race condition in PUP installation abortion.
- Fix freezes of emulator in case the PUP installation failed.
- Use fs::create_path as opposed to fs::create_dir as it is can create upper directories in case they are missing and is better in error handling.
- Report TAR errors on failure to create directories.
- Fix pup_object constructor to not crash on invalid PUP file header. (report an error)
- Fix pup_object::validate_hashes to not crash on invalid PUP file entries. (report an error)
- Do not call Qt functions inside a named_thread because it is wrong.
elad335
force-pushed
the
fw3
branch
5 times, most recently
from
c05ccc5
to
2bd0e56
Compare
Megamouse
reviewed
Feb 27, 2021
elad335
force-pushed
the
fw3
branch
3 times, most recently
from
c2f5cf3
to
72c890b
Compare
Megamouse
reviewed
Feb 27, 2021
Megamouse
reviewed
Feb 27, 2021
Megamouse
reviewed
Feb 27, 2021
* Fix race condition in PUP installation abortion. * Fix freezes of emulator in case the PUP installation failed due to filesystem errors. * Use fs::create_path as opposed to fs::create_dir as it is can create upper directories in case they are missing and is better in error handling. * Report TAR errors on failure to create directories. * Fix pup_object constructor to not crash on invalid PUP file header. (report an error) * Fix pup_object::validate_hashes to not crash on invalid PUP file entries. (report an error) * Do not call Qt functions inside a named_thread because it is wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.