fixed_typemap.hpp: make it a bit fool-proof #9881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require objects to be non-copyable (move is still allowed).
Change it to 0xE0000000 (SPU demarcation line)
|
Is there an actual error that you are fixing or is this hypothetical ? |
|
I noticed it when making changes to cellMusic, but they were fixed before this PR I believe. Also it's easy to forget to capture reference: |
|
hmm. well. idk. maybe someone else can review this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require objects in g_fxo (singletons with lifetime equalling emulated process) to be non-copyable (move is still allowed).
I noticed most of them are immovable anyway due to the presence of atomics and mutexes of sorts.
If accidental copy happends, it may be pretty bad with this design since it will be undesired but unnoticed.