Improve TAR loader #9908
Merged
Improve TAR loader #9908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elad335
commented
Mar 6, 2021
•
elad335
commented
- Fix header magic test.
- Rewrite code to not use so many filesystem calls.
- Add many more error checks.
- Add missing NUL filetype.
- octalToDecimal(header.size) has been fixed to use fixed 12 characters range instead of endless string.
- Add many optimizations.
- Fix possible signed overflows with int, use the unisgned u64 type instead which allows for greater files as well.
- Log errors.
elad335
force-pushed
the
tar
branch
2 times, most recently
from
743764a
to
627bf08
Compare
|
Removed #9907 dependency. |
elad335
commented
Mar 6, 2021
rpcs3/Loader/TAR.cpp
Outdated
| int decimalNumber = 0, i = 0, rem; | ||
| while (octalNumber != 0) | ||
| u64 i = -1; | ||
| const auto [ptr, err] = std::from_chars(sv.data(), sv.data() + sv.size(), i, 8); |
There was a problem hiding this comment.
from_chars allows much, much better error checking than atoi which is perfect for this. If theres any error i will remain UINT64_MAX which fails the later checks. Also supports unsigned types which the minus sign is not supported for it.
* Fix header magic test. * Rewrite code to not use so many filesystem calls. * Add many more error checks. * Add missing NUL filetype. * octalToDecimal(header.size) has been fixed to use fixed 12 characters range instead of endless string. * Add many optimizations. * Fix possible signed overflows with int, use the unisgned u64 type instead which allows for greater files as well. * Log errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.