Move sys_crashdump to it's own file and make it a module itself #9925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
reviewed
Mar 8, 2021
xddxd
force-pushed
the
functionsgobrrr
branch
2 times, most recently
from
507dd05
to
51eafcc
Compare
Megamouse
reviewed
Mar 8, 2021
|
I think these function should be registered twice in both modules, see #4257. |
|
I see. Will do. |
|
nvm, there was a regression since then, it used to have a module on its own in the past. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8301. Also fixes the same issue on Battlefield Hardline. Now it looks like this:
Ghidra image for reference: