Overlays: Implement individual element pulse #9943
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the pulse in the native UI is continuous and provides a rather bad user experience.
Sometimes it's hard to see that you selected a different element if the pulse glow is currently at 0.
This PR improves this behaviour by immediately highlighting the current element after a user interaction.
Technically this is achieved by resetting the sinus curve, using an individual offset for each element.
The offset is calculated with the current time and a hardcoded speed modifier.
The sinus reset values are kinda half assed and it would probably be easier to understand if we use cos.
Since the time is taken twice (once when setting the offset and once when drawing the elements) it won't be 100% accurate, but this should not be noticeable by any human being.
This affects the