Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlay refresh not erasing previous content #1976

Closed
Merudo opened this issue Jun 4, 2020 · 4 comments · Fixed by #1983
Closed

Overlay refresh not erasing previous content #1976

Merudo opened this issue Jun 4, 2020 · 4 comments · Fixed by #1983
Assignees
@Merudo
Labels
bug macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.
Projects
MapTool 1.8.0
Milestone
1.8.0

Comments

@Merudo
Copy link
Member

Merudo commented Jun 4, 2020

Describe the bug
Using overlay with the same name does not erase the content of the previous overlay. This leads to content being drawn on top of previous content.

To Reproduce
Steps to reproduce the behavior:

  1. Type [overlay("test"):{Old text}]
  2. Type [overlay("test"):{New}]
  3. The text "New" is printed on top of "Old text".

Expected behavior
The previous content of the overlay should not be kept.

MapTool Info

  • Version: develop
  • Install: New

Desktop (please complete the following information):

  • OS: Windows
  • Version: 10
@Merudo
Copy link
Member Author

Merudo commented Jun 4, 2020

Issue appeared after switching to Java 14: https://stackoverflow.com/questions/62186782/javafx-webview-transparent-webview-keeps-old-content-drawn

@Merudo Merudo added the bug label Jun 4, 2020
@Merudo Merudo self-assigned this Jun 4, 2020
Merudo added a commit to Merudo/maptool that referenced this issue Jun 4, 2020
@Merudo
Fix new overlay not erasing previous content
51ab1fd 
- Fix new overlay with the same name not erasing the previous overlay drawn on the screen
- Close RPTools#1976
@Merudo Merudo mentioned this issue Jun 4, 2020
Merged
@Merudo Merudo linked a pull request Jun 4, 2020 that will close this issue
Fix new overlay not erasing previous content #1983
Merged
@Merudo
Copy link
Member Author

Merudo commented Jun 4, 2020

PR #1983 fixes this.

@Phergus Phergus added this to To do in MapTool 1.8.0 via automation Jun 4, 2020
@Phergus Phergus added this to the 1.8.0 milestone Jun 4, 2020
@Phergus Phergus moved this from To do to In progress in MapTool 1.8.0 Jun 4, 2020
Merudo added a commit to Merudo/maptool that referenced this issue Jun 4, 2020
@Merudo
Change overlay reflection with invocation
0fa23e3 
- Replace the code to make WebPage invisible from reflection to invocation
- Discussed in RPTools#1976
@Merudo Merudo mentioned this issue Jun 4, 2020
Merged
@Merudo
Copy link
Member Author

Merudo commented Jun 4, 2020

PR #1984 changes the reflection to invocation, which is faster, more modern, provides better error traces and is more secure.

@Phergus Phergus moved this from In progress to Review in progress in MapTool 1.8.0 Jun 8, 2020
@Phergus
Copy link
Contributor

Phergus commented Jun 8, 2020

Tested. New content erases old content.

@Phergus Phergus moved this from Review in progress to Reviewer approved in MapTool 1.8.0 Jun 8, 2020
@Phergus Phergus added macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer. labels Jun 8, 2020
@Phergus Phergus closed this as completed Jun 16, 2020
@Phergus Phergus moved this from Reviewer approved to Done in MapTool 1.8.0 Jun 16, 2020
kwvanderlinde added a commit to kwvanderlinde/maptool that referenced this issue Aug 14, 2023
@kwvanderlinde
Remove workaround for RPTools#1976
10a2dcb 
The workaround was needed as old overlay contents were not being erased when the page background was transparent. That
problem no longer seems to exist, so the workaround has been removed in favour of always setting a fully transparent
background. This also seems to fix the blue flicker that has plagued overlays.
@kwvanderlinde kwvanderlinde mentioned this issue Aug 14, 2023
Merged
kwvanderlinde added a commit to kwvanderlinde/maptool that referenced this issue Aug 14, 2023
@kwvanderlinde
Remove workaround for RPTools#1976
9566e2d 
The workaround was needed as old overlay contents were not being erased when the page background was transparent. That
problem no longer seems to exist, so the workaround has been removed in favour of always setting a fully transparent
background. This also seems to fix the blue flicker that has plagued overlays.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Merudo Merudo

Labels
bug macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.
Projects
No open projects
MapTool 1.8.0
  
Done
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

Fix new overlay not erasing previous content Merudo/maptool
2 participants
@Merudo @Phergus