Attempt to fix overlay flicker #4246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workaround was needed as old overlay contents were not being erased when the page background was transparent. That problem no longer seems to exist, so the workaround has been removed in favour of always setting a fully transparent background. This also seems to fix the blue flicker that has plagued overlays.
kwvanderlinde
force-pushed
the
bugfix/4241-stat-sheet-blue-flicker
branch
from
10a2dcb
to
9566e2d
Compare
cwisniew
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Attempts to fix #4241
Description of the Change
There was a workaround introducedd for #1976 where we set the overlay page background to something not-quite-transparent, otherwise the overlay contents might not be cleared. Unfortunately this appears to be the cause of the flickering that overlays are known to have. This PR removes the workaround and always sets the page to have a transparent background.
It is necessary to set the page background to invisible in
updateContents()rather than just leaving it up tohandlePage(). I found that if a stat sheet has content that takes a bit to load (e.g., Rev's "Anim" stat sheet), the overlay would render as pure white for a moment before transitioning to transaprent.Possible Drawbacks
Documentation Notes
Release Notes
This change is