Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package names #3998

Merged

Conversation

kwvanderlinde
Copy link
Collaborator

@kwvanderlinde kwvanderlinde commented Apr 24, 2023

Identify the Bug or Feature request

#3997

Description of the Change

The files under src/main/java/net/rptools/maptool/client/ui/token/dialog/edit/ have been updated to make their package name match the directory structure.

Possible Drawbacks

Should be none

Documentation Notes

N/A

Release Notes

N/A


This change is Reviewable

@thelsing
Copy link
Collaborator

I really wonder how it ever compiled with the wrong package names. I always thought the compiles checks those.

@kwvanderlinde
Copy link
Collaborator Author

I thought so too. Somehow the .class file was being put under build/classes/java/main/net/rptools/maptool/client/ui/token to match the declared package name, so something was smoothing that over for us.

@cwisniew cwisniew added this pull request to the merge queue Apr 25, 2023
Merged via the queue into RPTools:develop with commit 72e228c Apr 25, 2023
4 checks passed
@cwisniew cwisniew added the bug label Jun 11, 2023
@kwvanderlinde kwvanderlinde deleted the refactor/3997-fix-package-names branch July 18, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

None yet

3 participants