Fix for MapTool Freeze when using an asset that can't be found on macro button #4182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
fixes #4163
Description of the Change
Changed the client handler put asset call so that the adding of the asset to the asset manager occurs on the current thread rather than a deferred Swing thread. As the memory cache is thread safe, this is fine, and it avoids the issue where Swing is blocking waiting for an image which currently locks up MapTool.
Possible Drawbacks
Should be none
Documentation Notes
Missing assets used in macro buttons OR![]()
tags in chat or frame/dialog should no longer cause MapTool to lock up.
Release Notes
This change is