Reenforce uniqueness of attached light sources as in ye olden days #4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Has to add back `AttachedLightSource.getId()` to make this work well, but added cautions against certains temptations with it.
cwisniew
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #4376
Description of the Change
A casualty of the protobuf changes in 1.12 was the removal of uniqueness checks in
Token.lightSourceList. This PR adds back the necessary checks to make sure we don't get duplicate lights and auras on a token.Possible Drawbacks
Likely none, unless someone discovered and depended specifically on have multiple auras via
setLight().Documentation Notes
N/A
Release Notes
This change is