UI text - Campaign Properties Dialogue #4635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [com.google.guava:guava](https://github.com/google/guava) from 32.1.3-jre to 33.0.0-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps com.google.protobuf:protobuf-java-util from 3.25.1 to 3.25.2. --- updated-dependencies: - dependency-name: com.google.protobuf:protobuf-java-util dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [com.google.protobuf:protoc](https://github.com/protocolbuffers/protobuf) from 3.25.1 to 3.25.2. - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl) - [Commits](protocolbuffers/protobuf@v3.25.1...v3.25.2) --- updated-dependencies: - dependency-name: com.google.protobuf:protoc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Successive building up an `Area` union by successive calls `Area.add()` is very slow, as each call needs to deal with more and more complex geometry. The new `GeometryUtil.destructiveUnion()` avoids this by instead unioning the input areas pairwise, then unioning those results pairwise, etc., until a final result is achieved. The same number of `Area.add()` calls are made, but since the majority of them deal only with simple geometry the result is much faster. There is a slightly slower `GeometryUtil.union()` that is implemented on top of `GeometryUtil.destructiveUnion()`, but does not modify the input.
The first big win is to avoid calculating a separate union for `visionArea` and `meta`, instead calculating `visionArea` as a union, then adding it to `meta`. The second win is to use `GeometryUtil.destructiveUnion()` to significantly reduce the cost of creating `visionArea` for long paths. New timers have been added to measure how long it takes to get all the visible areas along the path, to union them up, and to add them to the token's exposed area.
Updated MapFunctions CreateMap to use this. Updated InputFunction to use this.
- Right-align labels - Remove trailing colons - Align token property type label - Button tooltips Hyphenation
…o UI_Text_Campaign_Properties
|
|
cwisniew
approved these changes
Jan 17, 2024
cwisniew
added
the
code-maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4634
Description of the Change
Tidying up presentation and language
Possible Drawbacks
none
Documentation Notes
n/a
Release Notes
n/a
This change is