Add mapName argument to functions in TokenImage.java, Close #541 #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merudo
force-pushed
the
TokenImage
branch
2 times, most recently
from
fb9e231
to
156862a
Compare
Add mapName as optional argument (defaults to the current map) in the following functions in TokenImage:
getTokenImage
getTokenPortrait
getTokenHandout
setTokenImage
setTokenPortrait
setTokenHandout
setTokenOpacity
getTokenOpacity
Add optional parameter tokenId to these functions:
getTokenImage
getTokenPortrait
getTokenHandout
Close RPTools#541
As proposed in RPTools#549, remove the redundant putToken() calls for the following functions: setTokenImage(), setTokenPortrait(), setTokenHandout() and setTokenOpacity() all of which now call MapTool.serverCommand().putToken once only, and do not call zone.putToken() directly.
Phergus
reviewed
Aug 9, 2019
There was a problem hiding this comment.
Sounds good to me.
Reviewable status: 0 of 2 files reviewed, all discussions resolved
Phergus
approved these changes
Aug 9, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mapName as optional argument (defaults to current map) in the following functions in TokenImage:
Add optional parameter tokenId to these functions:
Close #541
This change is