Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mapName argument to functions in TokenImage.java, Close #541 #542

Merged
merged 2 commits into from Aug 9, 2019
Merged

Add mapName argument to functions in TokenImage.java, Close #541 #542

merged 2 commits into from Aug 9, 2019

Commits on Aug 6, 2019

  1. Add optional mapName argument to functions in TokenImage.java 

    Add mapName as optional argument (defaults to the current map) in the following functions in TokenImage:

        getTokenImage
        getTokenPortrait
        getTokenHandout
        setTokenImage
        setTokenPortrait
        setTokenHandout
        setTokenOpacity
        getTokenOpacity

Add optional parameter tokenId to these functions:

        getTokenImage
        getTokenPortrait
        getTokenHandout

Close RPTools#541
    @Merudo
    Merudo committed Aug 6, 2019
    Copy the full SHA
    cc95d54 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2019

  1. Removed redundant putToken() calls 

    As proposed in RPTools#549, remove the redundant putToken() calls for the following functions:

setTokenImage(), setTokenPortrait(), setTokenHandout() and setTokenOpacity()

all of which now call MapTool.serverCommand().putToken once only, and do not call zone.putToken() directly.
    @Merudo
    Merudo committed Aug 8, 2019
    Copy the full SHA
    472f755 View commit details
    Browse the repository at this point in the history