-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bisg vignette #70
Bisg vignette #70
Conversation
@jcburke -looks like you need to fix a merge conflict again - I suggest trying the web editor in this case since there are just a few lines in bisg.Rmd to fix |
I realized this paragraph, needs the following changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good. I like the maps.
The header might need additional lines to ensure that CMD check runs the vignette. Once that happens, I think some of the code blocks might break since they're importing data on the Jupyter Hub.
I am planning on updating wru_predict_race_wrapper
and precinct_agg_combine
based on Loren's suggestions, which will probably impact a few lines in this vignette. I'll ping you when I send those PRs in.
Made corrections to BISG vignette introduction and added information stating that the tigris package is publicly accessible and can be used to load shape files.
Removed sourcing wru wrapper and voter_utils fuctions.
…for the BISG vignette
… and added tidy::extract to the BISG vignette
…e bisg.Rmd file but knit is failing..
…out these lines of code to evaluate whether georgia_census.rda was loading and if it was causing an error for knitting/building the BISG vignette.
…age form the master branch of github.
@scottyhq and @woodsp , I think the tigris package (for downloading shape files from the census) may be having trouble loading because the rgdal dependency is unable to load. So, it can't get the block shape files. I tried to load the rgdal and tigris packages on my local and loading the block shape files worked. Any insight on how to remedy this? is it similar to the issue we are having with loading censusxy for the geocoding vignette? |
Yes, if possible (if the data files for the vignette are small) you can include them in the package and comment out the tigris API call to retrieve them in your vignette. Much like a cooking show... your commented code shows how it's done, but the retrieved product is there in case there are network issues |
Okay, I am going to include a subsetted version of the shape file in the data folder for the package and instruct the user on how to load it using tigris with commented out code as an alternative as well. Thanks for your help! |
…ck and tract information relative to the voter file tract and block information. The shape file is named gwin_fulton_shape.rda. I also created some alternative code that has been commented out for installing tigris and loading the shapefile using the tigris package.
…ompare into bisg_vignette
Remove tidyverse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Checks are all passing on my machine too.
title: "Bayesian Improved Surname Geocoding (BISG)" | ||
output: rmarkdown::html_document | ||
vignette: > | ||
%\VignetteIndexEntry{bisg} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed in the build that this entry should be "Bayesian Improved Surname Geocoding (BISG)" to display correctly with browseVignettes().
Perform BISG using the following functions:
dedupe_voter_file()
merge_shape_file()
wru_predict_race_wrapper()
The text needs to be updated though and re-edited for better display of possibly graphic information related to BISG, and overall a more concise walk-through.
The vignette also adds plots (barplot and choropleth maps for BISG race/ethnicity predictions)