fix: support bash v3 by removing array usage #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MacOS users only have bash v3 by default (due to licensing)
XECDesign
reviewed
Sep 5, 2023
|
I'll leave this hanging for a little bit, since I'm not a Docker or MacOS user. Hoping that will give time for people who are to provide some feedback. |
Tested and it seemed to work fine for me. macOS Ventura, latest Docker version. Image generated fine, however failed on export due to running out of storage (my fault) |
|
@XECDesign Did this commit break using "PRESERVE_CONTAINER=1 CONTINUE=1" ? |
XECDesign
pushed a commit
that referenced
this pull request
Oct 11, 2023
wandering-andy
pushed a commit
to wandering-andy/pi-gen
that referenced
this pull request
Oct 15, 2023
wandering-andy
pushed a commit
to wandering-andy/pi-gen
that referenced
this pull request
Oct 15, 2023
kayhannay
pushed a commit
to kayhannay/efalive_pi
that referenced
this pull request
Feb 12, 2024
kou029w
pushed a commit
to chirimen-oh/chirimen-lite
that referenced
this pull request
Aug 20, 2024
UmeshMohan-Dozee
pushed a commit
to DozeeRnD/pi-gen
that referenced
this pull request
Sep 18, 2024
UmeshMohan-Dozee
pushed a commit
to DozeeRnD/pi-gen
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve compatibility of the
docker-compose.yamlscript by supporting bash v3. MacOS users only have bash v3 by default (due to licensing).