[QPlayBridge]: New Bridge #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somini
commented
Apr 30, 2019
teromene
requested changes
May 2, 2019
|
Thanks for the review, commited those changes. |
|
It's still erroring out here: |
There was a problem hiding this comment.
Hey, nice bridge. Find below two suggestions
It's still erroring out here:
The getIcon function is optional and should return a direct link to the favicon. Please try to avoid loading contents in this function. The following code should work fine.
public function getIcon() {
return 'https://s3.amazonaws.com/unode1/assets/4957/r3T9Lm9LTLmpAEX6FlSA_apple-touch-icon.png';
}If the location of the icon changes, leaving the function out is probably the best option.
Remove fetching data on `getIcon`
Appease Travis
|
Many thanks for the review, commited your (thoughtful) recommendations. |
|
Thanks for taking in account @logmanoriginal's requests ! Merged ! |
infominer33
pushed a commit
to web-work-tools/rss-bridge
that referenced
this pull request
Apr 17, 2020
* [QPlayBridge]: New Bridge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another super specific bridge, but this site uses the uscreen platform, it might be used as a template for other sites.
The other public sites I tested hide all this from anonymous users, so I scrapped the generic version of this.