Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ArtStationBridge] Added new bridge #1122

Merged
merged 13 commits into from
May 8, 2019

Conversation

thefranke
Copy link
Contributor

Adds a new bridge for the latest ten items of a search query on ArtStation. User profiles already have support for RSS, so there's no need to enhance this bridge.

Copy link
Member

@logmanoriginal logmanoriginal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I see you have already fought battle with Travis, sorry about that.
Find below a few comments for improvements. Travis should stop complaining after fixing these.

bridges/ArtStationBridge.php Outdated Show resolved Hide resolved
bridges/ArtStationBridge.php Outdated Show resolved Hide resolved
bridges/ArtStationBridge.php Show resolved Hide resolved
bridges/ArtStationBridge.php Show resolved Hide resolved
bridges/ArtStationBridge.php Outdated Show resolved Hide resolved
bridges/ArtStationBridge.php Outdated Show resolved Hide resolved
logmanoriginal and others added 7 commits May 3, 2019 22:25
Co-Authored-By: thefranke <thefranke@users.noreply.github.com>
Co-Authored-By: thefranke <thefranke@users.noreply.github.com>
Co-Authored-By: thefranke <thefranke@users.noreply.github.com>
Co-Authored-By: thefranke <thefranke@users.noreply.github.com>
@teromene teromene merged commit a9e2574 into RSS-Bridge:master May 8, 2019
@teromene
Copy link
Member

teromene commented May 8, 2019

Thanks for taking in account @logmanoriginal 's comments and congrats for winning that battle against Travis 😄 !
Merged !

@thefranke
Copy link
Contributor Author

Haha, thank you! I'll give the battle against Travis another go soon I think with another bridge ;-)

@teromene
Copy link
Member

teromene commented May 8, 2019

Please do ! We are always welcoming new bridges ! And I am afraid that Travis is still hungry...

infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
* [ArtStationBridge] Added new bridge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants