Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MastodonBridge] Add a bridge to Mastodon #1178

Merged
merged 10 commits into from
Jun 21, 2019
Merged

[MastodonBridge] Add a bridge to Mastodon #1178

merged 10 commits into from
Jun 21, 2019

Conversation

husim0
Copy link
Contributor

@husim0 husim0 commented Jun 20, 2019

Hello,

I made a little bridge for Mastodon. Indeed Mastodon provides atom feeds but they are not usable in a RSS aggregator (title is for example "New status by user"). Feed example.

It's an improvement about solution proposed here. You can filter if you don't want boots nor answers to other toots.

It's my first contribution, please be kind to me :) I'll be glad to improve it if necessary.

Copy link
Member

@logmanoriginal logmanoriginal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Thanks for the PR 👍

Find below a few comments for consideration. Please also take a look at the test results from Travis, most of them are about whitespace and double-quotes.

bridges/MastodonBridge.php Outdated Show resolved Hide resolved
bridges/MastodonBridge.php Outdated Show resolved Hide resolved
bridges/MastodonBridge.php Outdated Show resolved Hide resolved
bridges/MastodonBridge.php Outdated Show resolved Hide resolved
husim0 and others added 4 commits June 21, 2019 14:59
Co-Authored-By: LogMANOriginal <LogMANOriginal@users.noreply.github.com>
Co-Authored-By: LogMANOriginal <LogMANOriginal@users.noreply.github.com>
Copy link
Contributor Author

@husim0 husim0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good. I don't know how to use properly code review in Github, sorry.

@logmanoriginal
Copy link
Member

I don't know how to use properly code review in Github, sorry.

You did everything correctly 👍
Travis seems to have a stroke though. Give me a few minutes to look through the error messages, they are not very descriptive: https://travis-ci.org/RSS-Bridge/rss-bridge/jobs/548681245

Copy link
Member

@logmanoriginal logmanoriginal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find below some comments. This should satisfy Travis.

bridges/MastodonBridge.php Outdated Show resolved Hide resolved
bridges/MastodonBridge.php Outdated Show resolved Hide resolved
bridges/MastodonBridge.php Outdated Show resolved Hide resolved
husim0 and others added 4 commits June 21, 2019 17:08
Co-Authored-By: LogMANOriginal <LogMANOriginal@users.noreply.github.com>
Co-Authored-By: LogMANOriginal <LogMANOriginal@users.noreply.github.com>
Co-Authored-By: LogMANOriginal <LogMANOriginal@users.noreply.github.com>
@logmanoriginal
Copy link
Member

Seems to be working now. Thanks again for your contribution 🥇

@logmanoriginal logmanoriginal merged commit e2bca5b into RSS-Bridge:master Jun 21, 2019
infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants