[ParameterValidator] Ensure context has all user provided parameters #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if a bridge had a set of parameters like:
const PARAMETERS = array(
'ContextA' => array(
'Param1' => array(
'name' => 'Param1',
'required' => true
)
),
'ContextB' => array(
'Param1' => array(
'name' => 'Param1',
'required' => true
),
'Param2' => array(
'name' => 'Param2',
'required' => true
)
)
)
and a query specifying both Param1 and Param2 was provided a 'Mixed
context parameters' error would be returned. This change ensures
ContextA in the above example would not be considered a relevant context.
|
Very nice, thanks for the PR 👍 |
infominer33
pushed a commit
to web-work-tools/rss-bridge
that referenced
this pull request
Apr 17, 2020
…SS-Bridge#1211) * [ParameterValidator] Ensure context has all fields Previously if a bridge had a set of parameters like: const PARAMETERS = array( 'ContextA' => array( 'Param1' => array( 'name' => 'Param1', 'required' => true ) ), 'ContextB' => array( 'Param1' => array( 'name' => 'Param1', 'required' => true ), 'Param2' => array( 'name' => 'Param2', 'required' => true ) ) ) and a query specifying both Param1 and Param2 was provided a 'Mixed context parameters' error would be returned. This change ensures ContextA in the above example would not be considered a relevant context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if a bridge had a set of parameters like:
and a query specifying both
Param1andParam2was provided aMixed context parameterserror would be returned. This change ensuresContextAin the above example would not be considered a relevant context.Not sure if this is necessarily needed since 1591e18 but it might be nice for completeness.