[HaveIBeenPwnedBridge] Add item limit parameter, set default limit to 20 #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
20 is an acceptable default limit, but I think things like this should be user-definable. |
|
To implement @triatic's proposal, add a new parameter: 'items_limit' => array(
'name' => 'Limit the number of returned items',
'type' => 'number',
'defaultValue' => 20,
)And use it, instead of the hardcoded $this->getInput('items_limit') |
VerifiedJoseph
changed the title
|
Merged, thanks ! |
VerifiedJoseph
deleted the
VerifiedJoseph-HaveIBeenPwnedBridge-limit-feed-items-2
branch
infominer33
pushed a commit
to web-work-tools/rss-bridge
that referenced
this pull request
Apr 17, 2020
… 20 (RSS-Bridge#1219) * Add `item_limit` parameter to allow user to control number of item returned by bridge. Suggested by @triatic and @somini (code).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the parameter
item_limitthat allows the user to control the number of items returned by bridge. Default limit is 20.