Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RevolutBridge] Add new bridge #1321

Merged
merged 2 commits into from
Oct 28, 2019
Merged

[RevolutBridge] Add new bridge #1321

merged 2 commits into from
Oct 28, 2019

Conversation

dominik-th
Copy link
Contributor

Add bridge for the Revolut blog https://blog.revolut.com/

@somini
Copy link
Contributor

somini commented Oct 12, 2019

LGTM. Travis complains about line 75, but I actually prefer the code as-is.

@teromene
Copy link
Member

I believe that line 75 would actually be better if it was line-splited after variables, and not separating two strings.

@dominik-th
Copy link
Contributor Author

I really disliked the way it looks, being split after the variables.

Now I am using the PHP Simple HTML DOM Parser to insert the variables into the string. What do you think about it?

@teromene teromene merged commit f2346fb into RSS-Bridge:master Oct 28, 2019
@teromene
Copy link
Member

Looks great to me ! LGTM !

@PoGo606
Copy link

PoGo606 commented Dec 1, 2019

What's the purpose of this bridge since there's already a feed available for this site ?
https://blog.revolut.com/rss/

@somini
Copy link
Contributor

somini commented Dec 1, 2019

What's the purpose of this bridge since there's already a feed available for this site ?
https://blog.revolut.com/rss/

It even has the full post contents.

This PR has a couple months, I'm not sure this was advertised on the page on this was opened and merged.

I agree that removing this bridge would be acceptable.

@logmanoriginal
Copy link
Member

Please correct me if I'm wrong, it doesn't look like the feed is linked on the page which makes it rather difficult to find. It probably makes sense to refactor the current bridge into a bridge that inherits from FeedExpander to pull from the feed that is available on the site.

@PoGo606
Copy link

PoGo606 commented Dec 3, 2019

Permit me to quote the README of rss-bridge :

RSS-Bridge is a PHP project capable of generating RSS and Atom feeds for websites that don't have one

The purpose of a bridge is to generate RSS feed when there's no other solution.
In this case a full RSS feed is provided, why re-inventing the wheel by adding a new bridge ?
I'm afraid if such a things is allowed, the bridges list will soon skyrocket.
I do understand that the RSS feed is not advertised on Revolut's webpage.
But any RSS tool will find it easily embeded in the page's code.

@logmanoriginal
Copy link
Member

I took another look at the website. It seems their RSS button is broken. There is supposed to be an RSS button next to the Twitter button (search for 'a.rss-button'):

image

Is this just on my end?
If they fixed their button, the bridge wouldn't be necessary.

@PoGo606
Copy link

PoGo606 commented Dec 3, 2019

Even though, there's still an existing feed available.
It's not shown visualy but still parsable in the web page by any RSS tool or any human (as long as they are curious to look at the code of the page).

Why RSS Bridge whould help fix a layout issue ?

@dominik-th
Copy link
Contributor Author

The rss icon on their page is white on white background and links to a non functional page
revolut_rss

But indeed they have the correct link in the websites head section so in my opinion we can delete the bridge

@logmanoriginal
Copy link
Member

Why RSS Bridge whould help fix a layout issue ?

Because it's awesome, even for little things like that 😁

The rss icon on their page is white on white background and links to a non functional page
revolut_rss

But indeed they have the correct link in the websites head section so in my opinion we can delete the bridge

Thanks for looking into it. Incidentally, their search bar is also broken (the search button appears in front of "Community" on my browser):

image

If you are a regular user, maybe send them a short message to point them in the right direction.
I'll remove the bridge with a remark in the release notes so people know what's up.

Thanks for your contribution 👍

logmanoriginal added a commit that referenced this pull request Dec 4, 2019
An official RSS feed is available at https://blog.revolut.com/rss/

Note that there is also an invisible "RSS" button next to the Facebook
and Twitter icons at the menu bar.

References #1321
infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
* [RevolutBridge] Add new bridge
infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
An official RSS feed is available at https://blog.revolut.com/rss/

Note that there is also an invisible "RSS" button next to the Facebook
and Twitter icons at the menu bar.

References RSS-Bridge#1321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants