Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MemcachedCache] loadData now returns null instead of false #1592

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

em92
Copy link
Contributor

@em92 em92 commented Jun 8, 2020

FileCache and SQLiteCache returns null on cache miss. This is important if using strict comparing (for example when using "===")

In #1562 (comment) @markwaters reported, that recent twitter rewrite didn't work when using Memcached.

Probably it happened due to strict comparing here and incorrect return value of loadData (false, instead of null):

$data = $cache->loadData();
if($data === null) {

Also, @markwaters, please report if this fix works for you.

FileCache and SQLiteCache returns null on cache miss. This is important if using strict comparing (for example when using "===")
@markwaters
Copy link

Thanks @em92 , I have made the change to MemcachedCache.php and will report back later.

@markwaters
Copy link

Thanks @em92 , I have made the change to MemcachedCache.php and will report back later.

Seems like it is working , Thanks again.

@teromene teromene merged commit e4c4ae8 into RSS-Bridge:master Jun 8, 2020
comlaterra pushed a commit to comlaterra/rss-bridge that referenced this pull request Sep 25, 2020
…ge#1592)

FileCache and SQLiteCache returns null on cache miss. This is important if using strict comparing (for example when using "===")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants