[FacebookBridge] Facebook bridge fix, swap to touch.facebook for groups #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
em92
suggested changes
Oct 26, 2020
SpangleLabs
force-pushed
the
facebook-bridge-fix
branch
from
b7c3029
to
e61f28d
Compare
…ook.com based parsing
…cebook.com based parsing
…acebook.com for groups
SpangleLabs
force-pushed
the
facebook-bridge-fix
branch
from
e61f28d
to
e7552bb
Compare
This was
linked to
issues
Oct 29, 2020
Closed
|
gj @joshcoales |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes group feeds, I think. Tested on a few groups.
It's swapping over to parsing using touch.facebook.com for groups. Users are still using www.facebook.com
I've got an automated integration test in here too, not sure how you'll feel about that. I'm curious how Travis likes it, as I've only ran it manually in PHP7.
Sorry this took a little while, I've had a very busy week moving house.
(If you're happy this PR is not spam, I would appreciate a
hacktoberfest-acceptedtag, but not required)