Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SymfonyCasts] Added new bridge #2000

Merged
merged 6 commits into from
Feb 28, 2021
Merged

[SymfonyCasts] Added new bridge #2000

merged 6 commits into from
Feb 28, 2021

Conversation

Park0
Copy link
Contributor

@Park0 Park0 commented Feb 27, 2021

Simple bridge to follow updates on SymfonyCasts.com

Simple bridge to follow updates on SymfonyCasts.com
Copy link
Contributor

@VerifiedJoseph VerifiedJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice, simple bridge. I have a few suggestions.

bridges/SymfonyCastsBridge.php Outdated Show resolved Hide resolved
bridges/SymfonyCastsBridge.php Outdated Show resolved Hide resolved
bridges/SymfonyCastsBridge.php Outdated Show resolved Hide resolved
bridges/SymfonyCastsBridge.php Show resolved Hide resolved
bridges/SymfonyCastsBridge.php Outdated Show resolved Hide resolved
Park0 and others added 3 commits February 27, 2021 23:27
Changed code based on feedback (Thanks VerifiedJoseph).

Co-authored-by: Joseph <joseph@verifiedjoseph.com>
Formatted the code
Copy link
Contributor

@VerifiedJoseph VerifiedJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes needed to pass Lint tests.

bridges/SymfonyCastsBridge.php Outdated Show resolved Hide resolved
bridges/SymfonyCastsBridge.php Outdated Show resolved Hide resolved
Co-authored-by: Joseph <joseph@verifiedjoseph.com>
@Park0
Copy link
Contributor Author

Park0 commented Feb 28, 2021

@VerifiedJoseph Thanks for your time

Copy link
Contributor

@VerifiedJoseph VerifiedJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me again with yet more suggestions.

bridges/SymfonyCastsBridge.php Outdated Show resolved Hide resolved
bridges/SymfonyCastsBridge.php Outdated Show resolved Hide resolved
Added maintainer
Removed debug code

Co-authored-by: Joseph <joseph@verifiedjoseph.com>
@Park0
Copy link
Contributor Author

Park0 commented Feb 28, 2021

PR 2000 has to be perfect :)

@em92 em92 merged commit a5f2175 into RSS-Bridge:master Feb 28, 2021
@em92
Copy link
Contributor

em92 commented Feb 28, 2021

gj @Park0 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants